Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new counter to Scheduler: events_fired; small Scheduler cleanup #449

Merged
2 commits merged into from
Oct 24, 2023
Merged

Added new counter to Scheduler: events_fired; small Scheduler cleanup #449

2 commits merged into from
Oct 24, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2023

closes #448

@ghost ghost added enhancement Enhancement or request component: sparta Issue is related to sparta framework labels Oct 24, 2023
@ghost ghost requested review from furuame and MichaelSchoenfelder-SiV October 24, 2023 01:54
@ghost ghost self-assigned this Oct 24, 2023
benoy-sifive
benoy-sifive approved these changes Oct 24, 2023
View reviewed changes
sparta/sparta/kernel/Scheduler.hpp Outdated Show resolved Hide resolved
sparta/src/Scheduler.cpp Outdated Show resolved Hide resolved
MichaelSchoenfelder-SiV
MichaelSchoenfelder-SiV approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@MichaelSchoenfelder-SiV MichaelSchoenfelder-SiV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see events_fired as a scheduler stat, so, yes, this is what I am asking for.

@ghost ghost merged commit 54a14fc into master Oct 24, 2023
8 checks passed
@ghost ghost deleted the knutel/issue_448_scheduler_counters branch October 24, 2023 19:59
github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
[ci skip] Added new counter to Scheduler: events_fired; small Schedul…
c527cce 
…er cleanup (#449)

* Added new counter to Scheduler: events_fired; small Scheduler cleanup 54a14fc
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furuame furuame Awaiting requested review from furuame

Assignees
No one assigned
Labels
component: sparta Issue is related to sparta framework enhancement Enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose scheduler event as a counter
2 participants
@benoy-sifive @MichaelSchoenfelder-SiV